[PATCH] D25485: [DAG] optimize negation of bool

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 17:21:28 PDT 2016

spatel added inline comments.

Comment at: test/CodeGen/PowerPC/negate-i1.ll:2-4
 ; RUN: llc < %s -mtriple=powerpc64-apple-darwin | FileCheck %s
 ; PR30661 - https://llvm.org/bugs/show_bug.cgi?id=30661
amehsan wrote:
> amehsan wrote:
> > please add -verify-machineinstrs to RUN command line. We make sure that we add it to all tests in our backend. Also  -mtriple=powerpc64le-unknown-linux-gnu is a more common triple.
> (I believe you just created and committed this in r284279. That is why I am asking to make a change in a place that is not modified in this patch :)
Correct - I added the test, so we could close PR30661 when this patch is committed. 

Note that the comment on line 1 gives away why I used the apple-darwin triple; I thought that would be an easier regex hack while adapting the script that we use for x86 auto-generation of CHECK lines. :)

Thank you for pointing out the improvements - I'll fix these up.


More information about the llvm-commits mailing list