[llvm] r284425 - [Support] Add support for "advanced" number formatting.

[Zachary Turner via llvm-commits]

I looked at the error message and I do believe this should fix it.  I will
rename it for now.  Long term I plan to put some of this in a new
namespace, but for now to get the build green I'm fine renaming this.

On Mon, Oct 17, 2016 at 4:06 PM Zachary Turner <zturner at google.com> wrote:

> I can easily just rename this to something else.  However, I can't do a
> modules build to test this out.  If I change the name of this enum, is that
> likely to fix it?
>
> On Mon, Oct 17, 2016 at 4:04 PM Tim Northover <t.p.northover at gmail.com>
> wrote:
>
> Hi Zachary,
>
> On 17 October 2016 at 13:57, Zachary Turner via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > +enum class HexStyle { Upper, Lower, PrefixUpper, PrefixLower };
>
> It looks like the modules build doesn't like this:
>
> http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA_build/670/console
> .
> It seems to be conflicting with an existing namespace HexStyle in
> MCInstPrinter.h.
>
> I *think* it's probably an ODR-violation that is just being picked up
> now because the modules build is stricter about such things. This is
> based on Clang complaining normally if it's done in the same
> translation unit, and the situation not being specifically mentioned
> in the allowable multi-definition clause of the standard as far as I
> can see.
>
> Could you have a bit of a think about the situation before recommitting?
>
> Cheers.
>
> Tim.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161017/72008bc8/attachment.html>