[llvm] r284425 - [Support] Add support for "advanced" number formatting.

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 16:04:12 PDT 2016

Hi Zachary,

On 17 October 2016 at 13:57, Zachary Turner via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> +enum class HexStyle { Upper, Lower, PrefixUpper, PrefixLower };

It looks like the modules build doesn't like this:
It seems to be conflicting with an existing namespace HexStyle in

I *think* it's probably an ODR-violation that is just being picked up
now because the modules build is stricter about such things. This is
based on Clang complaining normally if it's done in the same
translation unit, and the situation not being specifically mentioned
in the allowable multi-definition clause of the standard as far as I
can see.

Could you have a bit of a think about the situation before recommitting?



More information about the llvm-commits mailing list