[PATCH] D25645: [ADT] Add CachedHashString.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 15:25:10 PDT 2016

jlebar added a comment.

Rafael, Tim and I were looking for a second opinion -- does this seem to you like a sane thing to do?  The immediate problem I'm trying to solve here is to convert code that's using SmallSetVector<std::string>, which doesn't work after converting SmallSetVector to use DenseSet, because you can't store an std::string in a DenseSet.

Longer term, I hope to use something like this class to let us replace StringSet, StringMap, &co, but what we end up with in order to make that work may look quite different from this.  I was just planning to change it as necessary.


More information about the llvm-commits mailing list