[PATCH] D25644: [ADT] Move CachedHashString to a own header in ADT, and rename to CachedHashStringRef.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 15:17:32 PDT 2016


I think comparing hashes in isequal is the only change.  Pulled that
out into a separate patch, https://reviews.llvm.org/D25705.

On Sun, Oct 16, 2016 at 5:38 AM, Rafael Avila de Espindola
<rafael.espindola at gmail.com> wrote:
> This also changes some bits of the implementation, like comparing the hash
> in isequal. Could you make this do just the move and rename?
>
>
> LGTM if the implementation is not changed in this patch.
>
> On October 15, 2016 6:07:22 PM EDT, Justin Lebar via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> jlebar created this revision.
>> jlebar added a reviewer: timshen.
>> jlebar added a subscriber: llvm-commits.
>>
>> Reclaiming the name 'CachedHashString' will let us add a type with that
>> name that owns its value.
>>
>>
>> https://reviews.llvm.org/D25644
>>
>> Files:
>>   lld/ELF/InputSection.cpp
>>   lld/ELF/OutputSections.cpp
>>   lld/ELF/OutputSections.h
>>   llvm/include/llvm/ADT/CachedHashString.h
>>   llvm/include/llvm/MC/StringTableBuilder.h
>>   llvm/lib/MC/StringTableBuilder.cpp
>>   llvm/unittests/MC/StringTableBuilderTest.cpp
>>
>> ________________________________
>>
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.


More information about the llvm-commits mailing list