[PATCH] D25645: [ADT] Add CachedHashString.

[Tim Shen via llvm-commits]

timshen added inline comments.


================
Comment at: llvm/include/llvm/ADT/CachedHashString.h:94
+
+  // TODO: Use small-string optimization to avoid allocating.
+
----------------
timshen wrote:
> It is unfortunate to implement some of the std::string functionalities from scratch. Is there a way to implement it in terms of std::string?
More specifically, I'm asking for a member function `string& val();` that returns the underlying std::string object (it needs to exist first), so that CachedHashString compose better with other APIs that don't care about hashing.


https://reviews.llvm.org/D25645