[PATCH] D25690: [X86] Correct the number of bits in a fixup
Douglas Katzman via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 17 13:01:05 PDT 2016
dougk added a comment.
it looks like we need an MCAssembler on which to call getContext() and then Ctx->reportError(Fixup.getLoc(), "mumble").
Some of the other AsmBackends have started to have this plumbing added in.
However most of them actually guard the emission of the message with "if (Ctx)" because we usually don't have the context apparently, so you really can't get a nice source location anyway.
Without this change, we'll silently emit bogus code, so I think we should land it as-is, but do change it from assert to report_fatal_error. Are you ok with that?
More information about the llvm-commits