[PATCH] D25687: [PGO] fix bogus warning for merging empty llvm profile file

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 12:41:39 PDT 2016


yes please split it out.

On Mon, Oct 17, 2016 at 12:40 PM, Rong Xu <xur at google.com> wrote:

> xur added inline comments.
>
>
> ================
> Comment at: tools/llvm-profdata/llvm-profdata.cpp:159
>    for (auto &I : *Reader) {
> +    const StringRef FuncName = I.Name;
>      if (Error E = WC->Writer.addRecord(std::move(I), Input.Weight)) {
> ----------------
> davidxl wrote:
> > unrelated change?
> this is for the use-after-move fix I mentioned in the description.
> You want to split to another patch?
>
>
> https://reviews.llvm.org/D25687
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161017/18b521b2/attachment.html>


More information about the llvm-commits mailing list