[PATCH] D25684: [LLD][ARM] Support for R_ARM_TARGET2 relocation

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 10:47:16 PDT 2016

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with these changes.

Comment at: ELF/Driver.cpp:349
+static Target2Policy getTarget2Option(opt::InputArgList &Args) {
+  if (auto* Arg = Args.getLastArg(OPT_target2)) {
+    StringRef S = Arg->getValue();
`auto* ` -> `auto *`

Comment at: ELF/Target.cpp:1566
+  case R_ARM_TARGET2:
+    return getTarget2Expr();
   case R_ARM_TLS_GD32:
So the function seems to be used only once, so I'd inline it here and remove `getTarget2Expr`.


More information about the llvm-commits mailing list