[PATCH] D24414: Conditionally eliminate library calls where the result value is not used

[David Li via llvm-commits]

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm

(the original patch also includes handling of math libs which are not properly annotated by Clang FE. Is there a patch submitted for that fix?)



================
Comment at: lib/Transforms/Utils/LibCallsShrinkWrap.cpp:320
+
+  Type *ArgType = CI.getArgOperand(0)->getType();
+  if (!(ArgType->isFloatTy() || ArgType->isDoubleTy() ||
----------------
Add a comment (todo) for handle long double in other formats (either with conservative range test or precise handling).


https://reviews.llvm.org/D24414