[PATCH] D25620: DebugInfo: introduce DIAlignment type

Victor Leschuk via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 09:43:40 PDT 2016


vleschuk added a comment.

In https://reviews.llvm.org/D25620#571724, @aprantl wrote:

> After letting this sit for a few days, I think that using an unsigned (there doesn't seem to be much precedent for uint32_t) is the way to go. It's more readable than an opaque DIAlignment type (whose size isn't obvious from the name).


What about platforms where sizeof(unsigned) could be 2, standard does allow that, I'd rather use cstdint types.


https://reviews.llvm.org/D25620





More information about the llvm-commits mailing list