[PATCH] D9386: llvm.noalias - CaptureTracking needs to look through them

Jeroen Dobbelaere via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 03:10:47 PDT 2016

jeroen.dobbelaere added a comment.

Maybe 'passthrough' should return a boolean, indicating that we need to stop or not. (see code comment)
The places where it is called could become something like: 'if (passthrough()) return;

Comment at: lib/Analysis/CaptureTracking.cpp:244
+        if (Count++ >= Threshold)
+          return Tracker->tooManyUses();
Moving this piece of code with a 'return' into a lambda results in a behavior change: instead of directly breaking the outer while loop when the Threshold is reached, it will now keep doing work with whatever is on the worklist. I don't think this change in behavior was intended.


More information about the llvm-commits mailing list