[PATCH] D25639: Add ctor for string literal to StringRef, and make explicit the conversion from const char *

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 16 20:42:38 PDT 2016


zturner added a comment.

The only thing I'm not crazy about here is that the clang tidy check seems to blindly replace all calls to `s.c_str()` with `llvm::StringRef(s.c_str())`.  Is there any way to make it attempt to replace it with just `s` first, and only if that fails do you then try `llvm::StringRef(s.c_str())`?


https://reviews.llvm.org/D25639





More information about the llvm-commits mailing list