[PATCH] D23808: [X86][SSE] Add lowering to cvttpd2dq/cvttps2dq for sitofp v2f64/2f32 to 2i32

[Craig Topper via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:22248
+      }
+    }
+
----------------
RKSimon wrote:
> craig.topper wrote:
> > What types does the FIST code below handle? Should there be a return or llvm_unreachable after the MVT::v2f32 if. I don't think the FIST code was intended for a v2i32 result type so we shouldn't fallthrough into it.
> FP_TO_INTHelper only handles f32/f64/f80 scalar inputs, returning null for other inputs. rL283485 added tests to check this.
> 
> If you like I can add an early return at the end of the MVT::v2i32 block to make it clearer?
Yeah that's probably a little clearer.


================
Comment at: lib/Target/X86/X86InstrAVX512.td:6273
+            (VCVTTPD2DQZ128rm addr:$src)>;
+
   def : Pat<(v8f32 (fpround (loadv8f64 addr:$src))),
----------------
Why is this block under HasAVX512, but the patterns AVX pattersn in X86InstrSSE.td are only disabled if VLX is enabled?


Repository:
  rL LLVM

https://reviews.llvm.org/D23808