[PATCH] D25585: Add interface for querying physical hardware concurrency

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 14:41:51 PDT 2016


r284283

— 
Mehdi

> On Oct 14, 2016, at 2:30 PM, Teresa Johnson <tejohnson at google.com> wrote:
> 
> tejohnson added a comment.
> 
> In https://reviews.llvm.org/D25585#570756, @thakis wrote:
> 
>> The new test fails if I cmake with -DLLVM_ENABLE_THREADS=OFF. I guess this just needs a `#if LLVM_ENABLE_THREADS`?
> 
> 
> Yes that's right. With LLVM_ENABLE_THREADS=OFF hardware_concurrency will return 1, so the test will fail. I took the day off today, if you want to submit a fix then LGTM. I will do so tonight if you don't have a chance before then.
> 
> Thanks
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D25585
> 
> 
> 



More information about the llvm-commits mailing list