[PATCH] D25618: Check that emitted instructions meet their predicates on all targets except ARM, Mips, and X86.

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.


================
Comment at: lib/Target/AMDGPU/VOP1Instructions.td:539
   let VOP1 = 1;
+  let SubtargetPredicate = isGCN;
 }
----------------
dsanders wrote:
> @tstellarAMD: Hi Tom, I'm not sure if this line is correct or not. I've included it because a recent change (r284031) left a '?' in this field and that causes problems in tablegen. Is there a correct predicate to use here?
I think this needs to be isVI.


https://reviews.llvm.org/D25618