[PATCH] D25551: AMDGPU: Implement SGPR spilling with scalar stores

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 03:51:23 PDT 2016


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInsertWaits.cpp:626-627
+
+      if (I->getOpcode() == AMDGPU::S_ENDPGM)
+        EndPgmBlocks.push_back(&MBB);
     }
----------------
nhaehnle wrote:
> Please also handle the SI_RETURN case here and below.
I was specifically not handling that, but I guess it isn't a normal function return


https://reviews.llvm.org/D25551





More information about the llvm-commits mailing list