[PATCH] D24291: [mips] Add IAS support for dvp, evp

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 03:20:52 PDT 2016


sdardis marked 2 inline comments as done.
sdardis added a comment.

Thanks, committed as r284115.



================
Comment at: lib/Target/Mips/MicroMips32r6InstrInfo.td:1351
   dag OutOperandList = (outs);
   dag InOperandList = (ins GPR32Opnd:$rs);
+  string AsmString = "evp\t$rs";
----------------
vkalintiris wrote:
> I believe that this should be an out operand.
Yes, you're correct there.


================
Comment at: lib/Target/Mips/Mips32r6InstrFormats.td:48
 }
+def OPGROUP_COP0_DVPEVP : OPGROUP<0b010000>;
 def OPGROUP_COP1     : OPGROUP<0b010001>;
----------------
vkalintiris wrote:
> I don't think that we need the `_DVPEVP` suffix because we might need the COP0 opcode group again in the future.
Rechecking the .td files shows that OPGROUP_COP0 was defined in MipsEVAInstrFormats.td. I've renamed the def there to OPGROUP_COP0_TLB. At some point we will want to refactor the format files.


Repository:
  rL LLVM

https://reviews.llvm.org/D24291





More information about the llvm-commits mailing list