[PATCH] D25464: [NFC] Loop Versioning for LICM code clean up

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 02:37:51 PDT 2016


sbaranga accepted this revision.
sbaranga added a comment.

LGTM



================
Comment at: lib/Transforms/Scalar/LoopVersioningLICM.cpp:522
+  // LoopVersioningLICM object.
+  AutoResetter Resetter(*this);
+
----------------
sbaranga wrote:
> This only releases the memory when running on a new loop. So it wouldn't make things better. The solution also looks a bit over-engineered.
Ok, Evgeny just explained to me that this would release the memory when it goes out of scope. I think it's fine now.


https://reviews.llvm.org/D25464





More information about the llvm-commits mailing list