[PATCH] D25545: ELF: Simplify handling of *_start/*_end symbols.

[Peter Collingbourne via llvm-commits]

It looks like the previous behavior (before your change) was to create the
symbols unconditionally which caused a duplicate symbol error with linker
scripts and your change prevented the error by introducing the addSynthetic
function which would define them only if they did not already exist.

As I mentioned in the commit message, this is almost exactly what
addOptionalSymbol is already doing, so there's no real functional change
here.

Peter

On Oct 14, 2016 01:31, "Eugene Leviant" <evgeny.leviant at gmail.com> wrote:

> evgeny777 added a comment.
>
> addSynthetic() was introduced to allow defining start/end symbols in
> linker scripts
>
> Please take a look at
> https://reviews.llvm.org/D23405
>
>
> https://reviews.llvm.org/D25545
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161014/53652e18/attachment.html>