[PATCH] D25588: Statistic/Timer: Include timers in PrintStatisticsJSON().

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 20:29:29 PDT 2016


MatzeB added a comment.

In https://reviews.llvm.org/D25588#569932, @hfinkel wrote:

> Why are we using JSON for this? Should we use YAML for consistency with other things we serialize to text?


Technically YAML is a superset of JSON so this is YAML. Though admittedly I just looked that up, this really was a "I don't care" decision, my first version used in http://reviews.llvm.org/D20995 used CSV but the reviewers rather liked JSON.

Maybe I can sneak the escape function into one of our yaml headers then. Though I probably don't want to use all the IO machinery in YAMLTraits.h just to output some key/value pairs...


Repository:
  rL LLVM

https://reviews.llvm.org/D25588





More information about the llvm-commits mailing list