[PATCH] D25575: test-suite: try to force many FP-dependent tests to compile with unaggressive FP optimization, add support for per-ISA reference outputs

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 13:43:05 PDT 2016


MatzeB added a comment.

I think we should uphold as a general principle that things like this are configurable from the outside and the automatic detection schemes are only used to set default values. This means using
`set(VARNAME ... CACHE ...)` in cmake to get a user configurable parameter. So that when the autodetection fails you have a quick and easy way to override it.

Did you mean to only present the minisat makefile here? This seems to contain unrelated changes to cmake/modules/SingleMultiSource.cmake and crudely disables fast-math and fp-contraction in a lot of other benchmarks...


https://reviews.llvm.org/D25575





More information about the llvm-commits mailing list