[PATCH] D25532: [GlobalISel] Get the AArch64 tests to work on Linux

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 09:14:51 PDT 2016


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: unittests/CodeGen/GlobalISel/CMakeLists.txt:3
   GlobalISel
+  CodeGen
   )
----------------
rovka wrote:
> t.p.northover wrote:
> > qcolombet wrote:
> > > That change shouldn't be part of this patch, should it?
> > I expect it's intentional. The linker on Linux has different name-resolution rules from macOS, I wouldn't be at all surprised if the unittest failed to link there without this line.
> Yup, it doesn't link without this. This might be a bug in the way our CMake files handle components, but I don't really know enough about our build system to tell.
> @beanz : What do you think?
Thanks for the information!


https://reviews.llvm.org/D25532





More information about the llvm-commits mailing list