[PATCH] D25518: [ELF] - Handle broken size field of compressed sections header.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 01:46:53 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D25518#568396, @ruiu wrote:

> When you add a check like this, I think you want to show that why this is special among other possible errors. Otherwise, we'd have tons of error checks in our code base and still the linker crashes for broken inputs.


This error check at least special for 32 bit hosts. As if overflow happens here, user will get probably get error "error uncompressing section" instead of real reason "uncompressed section size is too large". Isn't that useful ?


https://reviews.llvm.org/D25518





More information about the llvm-commits mailing list