[PATCH] D25536: [APFloat] Make APFloat an interface class to the internal IEEEFloat. NFC.

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 16:07:56 PDT 2016


timshen created this revision.
timshen added reviewers: hfinkel, chandlerc, iteratee, echristo.
timshen added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

The intention is to make APFloat an interface class, so that later I can add a second implementation class DoubleAPFloat to correctly implement PPCDoubleDouble semantic. The interface of IEEEFloat is not public, and can be simplified (currently it's exactly the same as the old APFloat), but that belongs to a separate patch.

DoubleAPFloat should look like:
class DoubleAPFloat {

  const fltSemantics *Semantics;
  std::unique_ptr<APFloat> APFloats;  // Two heap-allocated APFloats.

};

There is no functional change, nor public interface change.


https://reviews.llvm.org/D25536

Files:
  llvm/include/llvm/ADT/APFloat.h
  llvm/lib/Support/APFloat.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25536.74453.patch
Type: text/x-patch
Size: 71969 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161012/1195681b/attachment-0001.bin>


More information about the llvm-commits mailing list