[PATCH] D25532: [GlobalISel] Get the AArch64 tests to work on Linux

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 14:16:56 PDT 2016


t.p.northover added a comment.

Certainly worth a try. Historically I've found generic-OS tests more trouble than they're worth, but I suppose we can sort that if they really do become a problem. Just one comment on the bigger change:



================
Comment at: test/CodeGen/AArch64/GlobalISel/arm64-instructionselect.mir:1
-# RUN: llc -O0 -run-pass=instruction-select -verify-machineinstrs -global-isel %s -o - | FileCheck %s
+# RUN: llc -O0 -mtriple=aarch64-apple-ios -run-pass=instruction-select -verify-machineinstrs -global-isel %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=IOS
+# RUN: llc -O0 -mtriple=aarch64-linux-gnu -run-pass=instruction-select -verify-machineinstrs -global-isel %s -o - | FileCheck %s -check-prefix=CHECK -check-prefix=LINUX
----------------
It'd be better to specify `-relocation-model=pic` which should make sure the GOT gets used on Linux too. Hopefully that won't change anything else in this test.


https://reviews.llvm.org/D25532





More information about the llvm-commits mailing list