[PATCH] D25495: [ThinLTO] Avoid archive member collisions

[Davide Italiano via llvm-commits]

On Wed, Oct 12, 2016 at 1:07 PM, Rui Ueyama via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> ruiu added a comment.
>
> Does this work for --whole-archive?
>

I think so.

$ git diff
diff --git a/test/ELF/lto/thin-archivecollision.ll
b/test/ELF/lto/thin-archivecollision.ll
index bd754d8..4e07187 100644
--- a/test/ELF/lto/thin-archivecollision.ll
+++ b/test/ELF/lto/thin-archivecollision.ll
@@ -7,6 +7,10 @@
 ; RUN: ld.lld %t.o %t1.a %t2.a -o %t
 ; RUN: llvm-nm %t | FileCheck %s

+; Check we handle this case correctly even in presence of --whole-archive.
+; RUN: ld.lld %t.o --whole-archive %t1.a %t2.a -o %t
+; RUN: llvm-nm %t | FileCheck %s
+
 ; CHECK: T _start
 ; CHECK: T blah
 ; CHECK: T foo

$ ninja check-lld
[1/1] Running lld test suite
Testing Time: 4.79s
  Expected Passes    : 895
  Unsupported Tests  : 10
[davide at localhost build]$


Do you think it's OK to add this test (just to be sure we don't regress?)

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare