[PATCH] D25385: Make the FunctionComparator of the MergeFunctions pass a stand-alone utility in a separate file

Erik Eckstein via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 13:07:35 PDT 2016


eeckstein updated this revision to Diff 74426.
eeckstein added a comment.

I added a unit test for FunctionComparator. It mainly test the API of the class (I didn't want to replicate the test for functionality, which are covered by the MergeFunction pass tests).

Also, I made some functions private which are not covered by the API test and which I think are not important to be accessible - at this time, but it may change in future.


https://reviews.llvm.org/D25385

Files:
  include/llvm/Transforms/Utils/FunctionComparator.h
  lib/Transforms/IPO/MergeFunctions.cpp
  lib/Transforms/Utils/CMakeLists.txt
  lib/Transforms/Utils/FunctionComparator.cpp
  unittests/Transforms/Utils/CMakeLists.txt
  unittests/Transforms/Utils/FunctionComparator.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25385.74426.patch
Type: text/x-patch
Size: 107624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161012/3038fed2/attachment-0001.bin>


More information about the llvm-commits mailing list