[PATCH] D25495: [ThinLTO] Avoid archive member collisions

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 11:55:44 PDT 2016


davide added a comment.

In https://reviews.llvm.org/D25495#568482, @ruiu wrote:

> If we put aside (2) for now, all the plumbing of OffsetInArchive is just to create a unique filename, which I think I don't like. There are other ways to generate a deterministic unique filename. For example, you could add `static int Counter = 0` to BitcodeFile and use the counter value as part of a filename (and increment it every time you use it).


I'm not sure I like exposing a global with static lifetime to avoid threading informations properly into the linker. If it would be a awful lot of work, I'd agree with you, but it seems it's not.


https://reviews.llvm.org/D25495





More information about the llvm-commits mailing list