[PATCH] D25495: [ThinLTO] Avoid archive member collisions

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 11:50:33 PDT 2016


ruiu added a comment.

If we put aside (2) for now, all the plumbing of OffsetInArchive is just to create a unique filename, which I think I don't like. There are other ways to generate a deterministic unique filename. For example, you could add `static int Counter = 0` to BitcodeFile and use the counter value as part of a filename (and increment it every time you use it).


https://reviews.llvm.org/D25495





More information about the llvm-commits mailing list