[polly] r284023 - [ScopInfo/CodeGen] ExitPHI reads are implicit.

[Michael Kruse via llvm-commits]

2016-10-12 20:22 GMT+02:00 Tobias Grosser <tobias at grosser.es>:
>>  ; CHECK:         Arrays {
>>  ; CHECK-NEXT:        double MemRef_up_3_ph; // Element size 8
>>  ; CHECK-NEXT:        i32* MemRef_A[*]; // Element size 8
>> +; CHECK-NEXT:        double MemRef_up_3_ph; // Element size 8
>>  ; CHECK-NEXT:    }
>
> Hi Michael,
>
> am I reading this wrong or do we now have two ScopArrayInfo objects with
> the same name in this test case? This is not really what I would have
> expected.

One is MK_ExitPHI, the other MK_Value. How Polly prints them
unfortunately don't show their kinds.

Both are needed: MK_ExitPHI to the output of the scop, MK_Value as the
(read-only) input. That the scop output is something else than the
scop input should not be unexpected; we already can have eg. MK_Value
and MK_PHI for the same PHINode.

To clarify the situation, you could change MK_ExitPHI ScopArrayInfo
base names to add a suffix, like MK_PHI, but this is only a cosmetic
change. I'd prefer to add the kinds to the printout instead.

Michael