[PATCH] D25333: [LV] Avoid rounding errors for predicated instruction costs

Matthew Simpson via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 10:54:26 PDT 2016


mssimpso updated this revision to Diff 74401.
mssimpso added a comment.

Addressed Gil's comments

- Added a comment to the test indicating that the functionality being tested is not AArch64-specific.

I had originally intended to make the test target-independent using the force-target-instruction-cost flag to set the instruction costs. But this flag resets the costs after calculating the scalarization overhead and scaling the costs by block probability. So that doesn't help. I'm not sure of the best way to go about checking multiple targets without excessive duplication, so I went with adding the suggested "not AArch64-specific" comment for now. Thanks!


https://reviews.llvm.org/D25333

Files:
  lib/Transforms/Vectorize/LoopVectorize.cpp
  test/Transforms/LoopVectorize/AArch64/predication_costs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25333.74401.patch
Type: text/x-patch
Size: 7573 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161012/8cf4e475/attachment.bin>


More information about the llvm-commits mailing list