[PATCH] D25495: [ThinLTO] Avoid archive member collisions

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 21:03:50 PDT 2016


mehdi_amini added a comment.

In https://reviews.llvm.org/D25495#567829, @pcc wrote:

> It seems that this does not entirely solve the problem -- you will still have collisions if two files happen to have the same size.
>
> The gold plugin solves this problem by incorporating the byte offset within the archive file into the filename it passes to the LTO library. Would it be possible to do something similar here?


Will it solve the problem?
If you have two archives with the same size, and the two member with the same name are the first one in the archive, they'll likely start at the same offset, wouldn't you get a collision again?


https://reviews.llvm.org/D25495





More information about the llvm-commits mailing list