[PATCH] D25476: GVN-hoist: fix store past load dependence analysis (PR30216, PR30499)

[Daniel Berlin via llvm-commits]

dberlin accepted this revision.
dberlin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Transforms/Utils/MemorySSA.h:977
 
+bool instructionClobbersQuery(MemoryDef *MD,
+                              const MemoryLocation &UseLoc,
----------------
I would really rather not expose this version.
We should keep the interface as "memorydefs and memoryuses" as much as possible.

It also shouldn't be named instructionClobbersQuery.


So i would expect this to be something like

bool defClobbersUseOrDef(MemoryDef *MD, MemoryUseOrDef *MU, AliasAnalysis &AA);

Internally, it obviously will just call a version of instructionClobbersQuery, but that should be an API implementation detail.
I'm fine fixing this in a followup though.



https://reviews.llvm.org/D25476