[PATCH] D25345: [ThinLTO] Handle empty summaries during internalization

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 14:43:39 PDT 2016


tejohnson added a comment.

In https://reviews.llvm.org/D25345#567655, @mehdi_amini wrote:

> Sorry, forgot about this patch. My main concern last week was that I fear we're piling-up on top of a fragile foundation: that'd be building technical debt. So I was trying to narrow down how to make sure we're not on a slippery slope with the current situation.
>
> > I was referring to the model of preventing importing and renaming by suppressing the summary.
>
> I don't know what you referred to?


I'm referring to the model where we invoke llvm::moduleCanBeRenamedForThinLTO() to guard building a summary when we can't rename (e.g. due to inline assembly, or with https://reviews.llvm.org/D25359, due to module level assembly)


https://reviews.llvm.org/D25345





More information about the llvm-commits mailing list