[PATCH] D25478: Do not remove implicit defs in BranchFolder

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 14:30:59 PDT 2016


MatzeB added a comment.

Heh, this obviously solves the problems of the broken/missing liveness updates :)

The next question of course is whether this will degrade codegen quality. Do the jumps in those empty-but-implicit-defs blocks removed so we just have a fall-through? Does MachineBlockPlacement help with that?
I think a convincing answer would require diffing assembly generated with/without this patch on a set of benchmarks. test-suite with -save-temps=obj flag maybe?.


Repository:
  rL LLVM

https://reviews.llvm.org/D25478





More information about the llvm-commits mailing list