[PATCH] D996: hasPath

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 12:58:20 PDT 2016


I'm not sure if you're doing this manually or not, but if you have a
script of some sort: perhaps you can ping the commit thread only if
the authors have not responded in (say) 1 week?

-- Sanjoy


On Tue, Oct 11, 2016 at 12:47 PM, Eugene Zelenko
<eugene.zelenko at gmail.com> wrote:
> Hi, Sanjoy!
>
> On Mon, Oct 10, 2016 at 7:13 PM, Sanjoy Das
> <sanjoy at playingwithpointers.com> wrote:
>> Hi Eugene,
>>
>> On Thu, Oct 6, 2016 at 10:55 AM, Eugene Zelenko via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>
>>> I'll be good idea to ping authors/reviewers in other cases. Some
>>> revisions may be just forgotten. If some of them are obsolete, they
>>> should be abandoned.
>>
>> What do you think about pinging solely the author (i.e. not
>> llvm-commits)?  I wouldn't mind receiving an email for patches that
>> _I've_ checked in but not updated the phabricator review for, but I
>> generally agree with Chandler about the signal/noise ratio here.
>>
>> -- Sanjoy
>
> I think it's better to ping all people involved. Some may lost
> interest in project, sometimes author didn't have commit rights and
> clearly asked help from reviewer, sometimes patches may be obsolete.
>
> Anyway, it's better to not reach state of Augeas' stables then clean them.
>
> Eugene.



-- 
Sanjoy Das
http://playingwithpointers.com


More information about the llvm-commits mailing list