[PATCH] D25467: [ELF] - Alternative fix to prevent possible crash on large output.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 11:16:50 PDT 2016


ruiu added a comment.

The new functions seem too complicated. There are a lot of ways to crash the linker by giving incorrect input. We deliberately ignore some cases such as relocations having too large values. Why do you want to fix this specifically? This is not even the only place where overflow can happen. I think we should leave it as is.


https://reviews.llvm.org/D25467





More information about the llvm-commits mailing list