[PATCH] D25364: [LCSSA] Use linear algorithm for isRecursivelyLCSSAForm

Igor Laevsky via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 09:25:18 PDT 2016


igor-laevsky added a comment.

Hi Michael,

> Do I understand it correctly, that we'll be checking LCSSA only for the current loop after each loop-pass? I think it should be sufficient, because if a pass breaks LCSSA, we should fail when LPM proceeds to the parent loop. However, for the sake of easier debugging I would prefer to allow full verification as we have it right now too, probably under `-verify-loop-info` as well (or under another flag). It really helps to find the broken pass faster.

Yes, this is the plan. I will send patch up for review in a nearest future.


Repository:
  rL LLVM

https://reviews.llvm.org/D25364





More information about the llvm-commits mailing list