[PATCH] D25374: [DAGCombiner] Update most ADD combines to support general vector combines

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 09:08:00 PDT 2016


mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

LGTM

Although I'm curious - do you see this in real code?
To the best of my understanding, the major goal of DAG-level constant folding is to get rid of constants that weren't visible on the IR level. This happens with scalars quite a lot (e.g. because of GEP lowering), but I'm not sure I understand where "new" vector constants come from.


Repository:
  rL LLVM

https://reviews.llvm.org/D25374





More information about the llvm-commits mailing list