[PATCH] D25371: [ELF] - Fixed assertion fail when symbol table has invalid sh_info value.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 02:12:20 PDT 2016


grimar added inline comments.


================
Comment at: ELF/Writer.cpp:368
+      if (!B->IsLocal)
+        fatal(getFilename(F) + ": invalid sh_info in symbol table");
       auto *DR = dyn_cast<DefinedRegular<ELFT>>(B);
----------------
ruiu wrote:
>  getFilename(F) + ": broken input file: getLocalSymbols returns a non-local symbol."
changed to "broken object" because "broken input file" makes this fatal to be 3 lines after formatting.


https://reviews.llvm.org/D25371





More information about the llvm-commits mailing list