[PATCH] D25022: Register Calling Convention - CodeGen Basic Additions

[Michael Kuperstein via llvm-commits]

mkuper added inline comments.


================
Comment at: lib/Target/X86/X86CallingConv.h:51
+    " doesn't support long double and mask types yet.");
+  return false; // gracefully continue the search - fallback to stack.
+}
----------------
MatzeB wrote:
> mkuper wrote:
> > mkuper wrote:
> > > The whole point is that we don't gracefully continue. :-)
> > > Can you make this llvm_unreachable?
> > I'm sorry, what I meant was - keep report_fatal_error, but make the *return* llvm_unreachable, if possible (I don't remember if this elicits warnings or not.)
> report_fatal_error() should be enough (and is declared with the noreturn attribute). Having both is unnecessary (if the unreachable comes 2nd we won't reach it) or wrong (if llvm_unreachable comes first  the compiler can optimize out everything including the following report_fatal_error).
Ah, ok, didn't realize report_fatal_error is declared noreturn. 
So we can just remove the "return false".


Repository:
  rL LLVM

https://reviews.llvm.org/D25022