[PATCH] D17095: [X86] Add X86FixupSeparateStack pass

[Michael LeMay via llvm-commits]

mlemay-intel added a comment.

In https://reviews.llvm.org/D17095#565252, @zvi wrote:

> In https://reviews.llvm.org/D17095#349469, @mlemay-intel wrote:
>
> > In https://reviews.llvm.org/D17095#349401, @eugenis wrote:
> >
> > > I may be able to look at this next week, but it is a bit outside of my area of expertise. Maybe find another reviewer?
> >
> >
> > Thank you.  I added you as a reviewer to all of these since they are all related to SafeStack, but I'll also look for another reviewer as you suggested.
> >
> > > Also, this needs tests. A lot of tests.
> >
> > I haven't yet found any existing tests in LLVM for a pass like this that I can use as an example, but I'll keep looking.  The challenge in writing a test for this pass that fits in the LLVM testing framework is that this pass modifies particular instructions depending on which registers get allocated as base registers for the instructions' memory operands, etc.  When a test is written as IR, I don't know of a way to control which registers get selected.
>
>
> Now that tests were added to this patch in .ll form, would it be better to change them to machine IR (.mir) form?


Yes, that's exactly the type of testing infrastructure I was looking for, but I didn't know it existed until you pointed it out.  Thanks.  I'll update this patch.


https://reviews.llvm.org/D17095