[PATCH] D24681: Optimize patterns of vectorized interleaved memory accesses for X86.

[Michael Kuperstein via llvm-commits]

mkuper added a comment.

I'm really sorry for coming into this review so late, but could you please also add stand-alone IR-level tests for the pass itself (and not only llc-level tests)?
Not only we'll get better testing granularity, but it'll be easier to see what the produced IR looks like, and whether it's really in the form we want.



================
Comment at: lib/Target/X86/X86InterleavedAccess.cpp:77
+    Value *NewBasePtr =
+        Builder.CreateGEP(nullptr, VecBasePtr, Builder.getInt32(Part));
+    Instruction *NewLoad =
----------------
There's an overload of CreateGEP that doesn't require the nullptr.


https://reviews.llvm.org/D24681