[PATCH] D25407: [lit] Remove (or allow specific) unused imports

[Brian Gesiak via llvm-commits]

modocache created this revision.
modocache added reviewers: ddunbar, echristo, delcypher, beanz.
modocache added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini.

Using Python linter flake8 on the utils/lit reveals several linter
warnings designated "https://reviews.llvm.org/F401: Unused import". Fix or silence these
warnings.

Some of these unused imports are legitimate, while some are part of lit's API.
For example, users of lit expect to be able to access `lit.formats.ShTest` in
their `lit.cfg`, despite the module hierarchy for that symbol actually being
`lit.formats.shtest.ShTest`. To silence linter errors for these lines,
include a "noqa" directive.


https://reviews.llvm.org/D25407

Files:
  utils/lit/lit.py
  utils/lit/lit/LitConfig.py
  utils/lit/lit/__init__.py
  utils/lit/lit/formats/__init__.py


Index: utils/lit/lit/formats/__init__.py
===================================================================
--- utils/lit/lit/formats/__init__.py
+++ utils/lit/lit/formats/__init__.py
@@ -1,4 +1,8 @@
-from __future__ import absolute_import
-from lit.formats.base import TestFormat, FileBasedTest, OneCommandPerFileTest
-from lit.formats.googletest import GoogleTest
-from lit.formats.shtest import ShTest
+from lit.formats.base import (  # noqa: F401
+    TestFormat,
+    FileBasedTest,
+    OneCommandPerFileTest
+)
+
+from lit.formats.googletest import GoogleTest  # noqa: F401
+from lit.formats.shtest import ShTest  # noqa: F401
Index: utils/lit/lit/__init__.py
===================================================================
--- utils/lit/lit/__init__.py
+++ utils/lit/lit/__init__.py
@@ -1,8 +1,5 @@
 """'lit' Testing Tool"""
 
-from __future__ import absolute_import
-from .main import main
-
 __author__ = 'Daniel Dunbar'
 __email__ = 'daniel at minormatter.com'
 __versioninfo__ = (0, 6, 0)
Index: utils/lit/lit/LitConfig.py
===================================================================
--- utils/lit/lit/LitConfig.py
+++ utils/lit/lit/LitConfig.py
@@ -83,7 +83,7 @@
             # a timeout per test. Check it's available.
             # See lit.util.killProcessAndChildren()
             try:
-                import psutil
+                import psutil  # noqa: F401
             except ImportError:
                 self.fatal("Setting a timeout per test requires the"
                            " Python psutil module but it could not be"
Index: utils/lit/lit.py
===================================================================
--- utils/lit/lit.py
+++ utils/lit/lit.py
@@ -1,5 +1,6 @@
 #!/usr/bin/env python
 
+from lit.main import main
+
 if __name__=='__main__':
-    import lit
-    lit.main()
+    main()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25407.74078.patch
Type: text/x-patch
Size: 1838 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161009/b81c18b3/attachment.bin>