[PATCH] D24816: [Target] move reciprocal estimate settings from TargetOptions to TargetLowering

[Sanjay Patel via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/trunk/include/llvm/Target/TargetLowering.h:2184
                                     MachineBasicBlock *MBB) const;
+  TargetRecip ReciprocalEstimates;
 };
----------------
echristo wrote:
> I figured with getTargetRecipForFunc we could remove this? It returns the struct...
Yes, there's big refactor/rewrite potential here - the current API/implementation is just awful. Fixing it will affect D25291, but it should be easy to adapt if that goes in first.

Let me start working on the refactor since it's not clear how long we'll need this solution. I did look into what the ideal (instruction-level) solution might look like and have a good lead: MD_fpmath can be extended for reciprocal estimates. I'll send a proposal to llvm-dev to see if anyone sees problems with that.


Repository:
  rL LLVM

https://reviews.llvm.org/D24816