[PATCH] D25342: Turn cl::values() (for enum) from a vararg function to using C++ variadic template

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 8 12:39:49 PDT 2016


mehdi_amini added a comment.

In https://reviews.llvm.org/D25342#565265, @EricWF wrote:

> This LGTM. but I can't approve LLVM patches.


Don't be so shy :)

I put it up for review because I wasn't sure about the variadic template, if there was something more straightforward to build the initializer list and/or initialize the vector. I trust that if it is fine to you, it can be committed :)


https://reviews.llvm.org/D25342





More information about the llvm-commits mailing list