[PATCH] D25384: [ThinLTO] Record references to aliases to calls

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 22:42:47 PDT 2016


tejohnson added inline comments.


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:116
         if (!CalledFunction->hasName() || CalledFunction->isIntrinsic())
           continue;
         auto ScaledCount = BFI ? BFI->getBlockProfileCount(&BB) : None;
----------------
mehdi_amini wrote:
> What if we have an alias to an unnamed function?
I thought these would all get named in the NameAnonGlobals pass? 

In fact, perhaps this should be an assert that we have a name?


https://reviews.llvm.org/D25384





More information about the llvm-commits mailing list