[PATCH] D25291: [AArch64] Optionally use the reciprocal estimation machinery

[Evandro Menezes via llvm-commits]

evandro added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:645
+                 ExtraStepsD = 3;
+  const bool UseRsqrt = STI.useRSqrt();
+
----------------
I guess that this should be qualified with `STI.hasNEON()`...


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4622
+  unsigned Opcode, const SDValue &Operand, unsigned &ExtraSteps) {
+  if (!ST.hasNEON())
+    return SDValue();
----------------
... and this check removed.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:4629
+      VT != MVT::v2f32 && VT != MVT::v4f32 &&
+      (!ST.hasFullFP16() ||
+       (VT != MVT::f16 && VT != MVT::v4f16 && VT != MVT::v8f16)))
----------------
I guess that target information should not be present here anymore.  But do `f16` types make sense when, though supported by the target, `TargetRecip` does not support them?


Repository:
  rL LLVM

https://reviews.llvm.org/D25291