[PATCH] D25374: [DAGCombiner] Update most ADD combines to support general vector combines

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 7 12:38:58 PDT 2016


mkuper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:829
+    return !Const->isOpaque();
+  return ISD::isBuildVectorOfConstantSDNodes(N.getNode());
+}
----------------
What if we have a BUILD_VECTOR of constants where one of the constants going into it is opaque?


Repository:
  rL LLVM

https://reviews.llvm.org/D25374





More information about the llvm-commits mailing list